JSON-RPC to graphQL migration#63
Merged
harshaalphafi merged 4 commits intomainfrom May 2, 2026
Merged
Conversation
Zorag44
requested changes
May 1, 2026
Zorag44
previously approved these changes
May 1, 2026
jangid
previously approved these changes
May 2, 2026
Contributor
jangid
left a comment
jangid
left a comment
There was a problem hiding this comment.
LGTM — clean migration from JSON-RPC to GraphQL-first initialization. Centralizing AlphalendClient into StrategyContext and removing the hardcoded 'mainnet' instances is a solid improvement. The missing await fix on updatePrices in singleAssetLooping.ts is a good catch too.
A few minor items to consider (non-blocking):
alphaVault.ts:claimAirdropstill creates a localAlphalendClientinstead of usingthis.context.alphalendClientlike every other strategyalphaVault.ts~line 1017 still hardcodesgetConstants('mainnet')— should probably begetConstants(this.context.blockchain.network)types.ts— the JSDoc ongraphqlUrlstill says "Sui blockchain client for network operations" (carried over fromsuiClient)
rishikesh-chavan
previously approved these changes
May 2, 2026
Contributor
|
scripts/testRun.ts still uses old SuiClient |
11felix
dismissed stale reviews from OctoSauce, rishikesh-chavan, jangid, and Zorag44
via
98a2fbb
OctoSauce
approved these changes
May 2, 2026
rishikesh-chavan
requested review from
Zorag44 and
rishikesh-chavan
and removed request for
Zorag44
rishikesh-chavan
approved these changes
May 2, 2026
jangid
approved these changes
May 2, 2026
Contributor
jangid
left a comment
jangid
left a comment
There was a problem hiding this comment.
LGTM — fixes look good. Minor remaining items (unused txBuildClient? option in BlockchainOptions, scripts/testRun.ts still on old API, stale doc in index.ts) are non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.